RussellSpitzer commented on code in PR #15241:
URL: https://github.com/apache/iceberg/pull/15241#discussion_r2770625421
##########
core/src/main/java/org/apache/iceberg/CherryPickOperation.java:
##########
@@ -82,7 +82,9 @@ public CherryPickOperation cherrypick(long snapshotId) {
set(SnapshotSummary.SOURCE_SNAPSHOT_ID_PROP, String.valueOf(snapshotId));
// Pick modifications from the snapshot
- for (DataFile addedFile : cherrypickSnapshot.addedDataFiles(io)) {
+ SnapshotFileChanges changes =
+ SnapshotFileChanges.builder(cherrypickSnapshot, io,
specsById).build();
Review Comment:
We technically don't have to use the cached utility here, but we use it in
the other usage within this file so I thought it was a bit clearer this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
