evindj commented on PR #553: URL: https://github.com/apache/iceberg-cpp/pull/553#issuecomment-3856340410
@zhjwpku as you can see windows is still failing. I see 3 options going forward. 1. we accept that windows is going to be broken for these cases, of course this is not great since we wan to properly support windows. 2. We always copy and everything build wise is happy but of course performance becomes a little bit of a concern. 3. we find a way to make it so that at compile time there is specific code for Windows. this could make the implementation complex. Overall, I am leaning towards doing (2) because most of those constants are pretty short strings so I would expect the performance hit to be minimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
