rdblue commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2771648997
########## core/src/main/java/org/apache/iceberg/deletes/PositionDeleteWriter.java: ########## @@ -60,7 +60,7 @@ public class PositionDeleteWriter<T> implements FileWriter<PositionDelete<T>, De private DeleteFile deleteFile = null; public PositionDeleteWriter( - FileAppender<StructLike> appender, + FileAppender<PositionDelete<T>> appender, Review Comment: You're right that we can't just change this since it's public. I think what we should do is add a private constructor that accepts the `FileAppender<PositionDelete<T>>` and add a `create` method for `FileWriterBuilderImpl` to use. Then we can deprecate this version, since we know that `PositionDelete<T>` is always what gets passed in through the `write` method. Unfortunately, `FileAppender<StructLike>` and `FileAppender<PositionDelete<T>>` have the same erasure, so creating the private constructor will require reordering args or adding a dummy argument. But once we remove the current constructor in 1.11, we can revert back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
