MisterRaindrop commented on PR #548: URL: https://github.com/apache/iceberg-cpp/pull/548#issuecomment-3871639483
> I just took a quick pass on the latest commit. Can we simplify the implementation like this: > > 1. Use a CMake option to enable S3. > 2. Define reserved iceberg properties for S3 and add functions to convert them to Arrow S3 options. > 3. To create a concrete S3FileIO, using Arrow API to create a S3FileSystem and wrap it by ArrowFileSystemFileIO. > 4. Register the factory to create FileIO of S3 to the registry before use. > 5. Add a file io utility to create the FileIO instance based on various condition. I have only implemented a demo so far. I'm not sure if there are any issues with the overall implementation approach and structure because some aspects haven't been fully discussed. Some parts might not be written **well**. Also, **I've been** busy lately, as you know the holiday **is** coming up. But I'll do **it** as soon as possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
