CTTY commented on issue #2065: URL: https://github.com/apache/iceberg-rust/issues/2065#issuecomment-3891801545
>> fn delete_stream( &self, locations: BoxStream<'static, Result>, ) -> BoxStream<'static, Result>; > What's the return value here? This is refering to [object_store::delete_stream](https://docs.rs/object_store/0.13.1/object_store/trait.ObjectStore.html#tymethod.delete_stream). quoting the doc: > The returned stream yields the results of the delete operations in the same order as the input locations. However, some errors will be from an overall call to a bulk delete operation, and not from a specific location. > If the object did not exist, the result may be an error or a success, depending on the behavior of the underlying store. I think it makes sense to return results for each objects we attempted to delete. But when looking at [Opendal](https://github.com/apache/opendal/blob/8658906606a83b5847325ed12190e5b40cfd0a31/core/core/src/types/operator/operator.rs#L1343), it does not return results for each object when `delete_stream`, it just returns `Result<()>`. Maybe there are existing ways in Opendal to better handle the results? cc @Xuanwo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
