rdblue commented on code in PR #15241:
URL: https://github.com/apache/iceberg/pull/15241#discussion_r2801585396


##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -112,7 +112,11 @@ public interface Snapshot extends Serializable {
    *
    * @param io a {@link FileIO} instance used for reading files from storage
    * @return all data files added to the table in this snapshot.

Review Comment:
   +1 for deprecating these methods. We've had issues with these in the past, 
like when we had to add `FileIO` to the signature. A utility class is the 
better option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to