kevinjqliu commented on code in PR #15244:
URL: https://github.com/apache/iceberg/pull/15244#discussion_r2809424702
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -128,7 +128,7 @@ public ParquetValueReader<?> message(
@Override
public ParquetValueReader<?> struct(
Types.StructType expected, GroupType struct,
List<ParquetValueReader<?>> fieldReaders) {
- // the expected struct is ignored because nested fields are never found
when the
+ // the expected struct is ignored because nested fields are never found
when the ID is missing
Review Comment:
i asked claude to write a better comment, heres what it came up with.
thoughts?
```
// Unlike ReadBuilder.struct(), this does not reorder fields to match
the expected schema
// or handle missing fields with defaults. Without field IDs in the
Parquet schema, fields
// cannot be matched by ID, so they are read in file order instead.
```
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -128,7 +128,7 @@ public ParquetValueReader<?> message(
@Override
public ParquetValueReader<?> struct(
Types.StructType expected, GroupType struct,
List<ParquetValueReader<?>> fieldReaders) {
- // the expected struct is ignored because nested fields are never found
when the
+ // the expected struct is ignored because nested fields are never found
when the ID is missing
Review Comment:
looks like there are a couple more instances of this
https://github.com/search?q=repo%3Aapache%2Ficeberg+%22the+expected+struct+is+ignored+because+nested+fields+are+never+found+when+the%22&type=code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
