Fokko commented on code in PR #15331:
URL: https://github.com/apache/iceberg/pull/15331#discussion_r2811101267
##########
open-api/rest-catalog-open-api.py:
##########
@@ -136,11 +136,59 @@ class ExpressionType(BaseModel):
class TrueExpression(BaseModel):
- type: Literal['true'] = Field('true', const=True)
+ type: Literal['true'] = Field(
+ 'true',
+ const=True,
+ example=[
+ 'true',
+ 'false',
Review Comment:
From an OpenAPI perspective, this is a bit awkward. The `Literal['true']`
tells us that only `true` is allowed, but the examples give other suggestions 😁
Maybe we want to fix this in a follow up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
