pvary commented on code in PR #15334:
URL: https://github.com/apache/iceberg/pull/15334#discussion_r2813797973
##########
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##########
@@ -75,13 +81,6 @@ protected BaseFileWriterFactory(
this.positionDeleteRowSchema = null;
}
- /**
- * @deprecated This constructor is deprecated as of version 1.11.0 and will
be removed in 1.12.0.
- * Position deletes that include row data are no longer supported. Use
{@link
Review Comment:
I removed the deprecation comment here because this method was introduced in
the current release cycle, before we decided to deprecate the entire class. Now
that the class itself is deprecated, and the replacement class doesn’t provide
a way to set the position‑delete row‑data schema, the constuctor is effectively
deprecated as well. However, since there’s no new equivalent method, we don’t
really have a suitable place to add a dedicated deprecation message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
