rdblue commented on code in PR #15328:
URL: https://github.com/apache/iceberg/pull/15328#discussion_r2819432126
##########
spark/v4.1/spark/src/jmh/java/org/apache/iceberg/spark/data/parquet/SparkParquetReadersFlatDataBenchmark.java:
##########
@@ -167,6 +169,21 @@ public void readUsingSparkReader(Blackhole blackhole)
throws IOException {
}
}
+ @Benchmark
+ @Threads(1)
+ public void readUsingRegistryReader(Blackhole blackHole) throws IOException {
Review Comment:
Do we need to test the direct method vs the registry method? I would expect
this to replace the current `readUsingIcebergReaderUnsafe` implementation since
this is the same reader implementation. We should make sure that there is not a
regression by running these benchmarks (for which it would be fine to leave
this method here) but I don't want to accumulate essentially dead code testing
the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
