steveloughran commented on code in PR #15275:
URL: https://github.com/apache/iceberg/pull/15275#discussion_r2822481223
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicTableUpdateOperator.java:
##########
@@ -101,4 +103,12 @@ public DynamicRecordInternal map(DynamicRecordInternal
data) throws Exception {
return data;
}
+
+ @Override
+ public void close() throws Exception {
+ super.close();
+ if (catalog instanceof Closeable) {
Review Comment:
FYI java17 has that new construct to make this a bit more elegant
```java
if (catalog instanceof Closeable rc) {
rc.close();
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
