nastra commented on code in PR #15368:
URL: https://github.com/apache/iceberg/pull/15368#discussion_r2827372575
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -867,7 +873,8 @@ public static PlanTableScanResponse planTableScan(
.withPlanStatus(PlanStatus.COMPLETED)
.withPlanId(planId)
.withFileScanTasks(initial.first())
- .withSpecsById(table.specs());
+ .withSpecsById(table.specs())
+ .withCredentials(DUMMY_STORAGE_CREDENTIALS);
Review Comment:
we're returning a dummy storage credential so that the Plan ID gets added to
the FileIO instance. If people feel too strongly about adding dummy
credentials here, I think it should also be possible to try and add them in
`TestRESTScanPlanning`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
