steveloughran commented on code in PR #15111:
URL: https://github.com/apache/iceberg/pull/15111#discussion_r2828156405
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -214,14 +215,60 @@ private ExecutorService executorService() {
return executorService;
}
+ /**
+ * Is a path in a schema of a filesystem where the hadoop trash policy
should be used to move to
+ * it to trash?
+ *
+ * @param toDelete path to delete
+ * @return true if the path is in the list of schemas for which the
+ */
+ @VisibleForTesting
+ boolean isTrashSchema(Path toDelete) {
Review Comment:
it has to depend on the target fs, and the APIs are not bonded to a specific
fs; in theory we could get delete(hdfs://) followed by delete(file). And for
viewfs some of the resolution happens inside the fs.
What I will do is fix the scan of the configuration file to only be done
once, with the string[] array cached for next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
