nastra commented on code in PR #15362:
URL: https://github.com/apache/iceberg/pull/15362#discussion_r2831522246


##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedValuesReader.java:
##########
@@ -37,44 +37,68 @@ interface VectorizedValuesReader {
   int DOUBLE_SIZE = 8;
 
   /** Read a single boolean */
-  boolean readBoolean();
+  default boolean readBoolean() {
+    throw new UnsupportedOperationException();

Review Comment:
   I would probably still mention the method name in the error msg here and in 
all the other ones: `readBoolean is not supported`. 
   This makes it slightly easier when someone accidentally calls such a method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to