shangxinli opened a new pull request, #570:
URL: https://github.com/apache/iceberg-cpp/pull/570
## Summary
- Rename `while_digits` to `whole_digits` in decimal parser (typo for
"whole" digits, the integer part before the decimal point)
- Add missing `{}` format placeholder in parquet writer error message so the
codec name is actually included
- Fix `batch = nullptr` to `*batch = nullptr` in
`EmptyRecordBatchReader::ReadNext()` so the caller's shared_ptr is properly
cleared
## Test plan
- Build verified locally
- All existing tests pass (`expression_test`, `util_test`, `parquet_test`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
