jx2lee commented on PR #3083:
URL: https://github.com/apache/iceberg-python/pull/3083#issuecomment-3945120582
@kevinjqliu
I took a pass at a refactoring (a draft 🤗 ) based on your two concerns:
1. `Config()` implicit IO (env + local config files)
2. import-time `_ENV_CONFIG` initialization causing config reads during
import
---
Direction I used is:
- make `Config()` a pure container (no implicit)
- add explicit `Config.load()` for file/env loading
- replace import-time `_ENV_CONFIG` with a lazy cached getter used by
`load_catalog()` / `list_catalogs()`
---
Would you mind taking a quick look and sharing any guidance on:
- whether changing `Config()` semantics so config loading is explicit (e.g.,
via `Config.load()`) is acceptable in scope for this issue
- any compatibility concerns I should watch for before opening a PR
Thanks — happy to adjust the approach based on your feedback. 👍🏽
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
