qlong commented on code in PR #15384:
URL: https://github.com/apache/iceberg/pull/15384#discussion_r2841985971
##########
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java:
##########
@@ -632,6 +633,8 @@ private boolean isNonNullPreserving(Bound<?> term) {
}
private static VariantObject parseBounds(ByteBuffer buffer) {
- return Variant.from(buffer).value().asObject();
+ // Explicitly use little-endian encoding for reading buffer
+ ByteBuffer littleEndian =
buffer.duplicate().order(ByteOrder.LITTLE_ENDIAN);
Review Comment:
I think we need to create a new buffer so the the
order(ByteOrder.LITTLE_ENDIAN) call does not change the encoding of the buffer
that is passed in. ParquetVariantReaders.readBinary creates a local buffer that
is not shared with anyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
