RussellSpitzer commented on code in PR #15422:
URL: https://github.com/apache/iceberg/pull/15422#discussion_r2843183454
##########
api/src/main/java/org/apache/iceberg/expressions/BoundLiteralPredicate.java:
##########
@@ -114,24 +114,28 @@ public boolean isEquivalentTo(Expression expr) {
// < 6 is equivalent to <= 5
return toLong(literal()) == toLong(other.literal()) + 1L;
}
+
Review Comment:
I don't really like how this looks, but having the newline after the
"break;" would make the regex look much more complicated ... maybe still worth
doing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
