amogh-jahagirdar commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2847804263
##########
core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java:
##########
@@ -87,7 +87,26 @@ private OutputFileFactory(
}
public static Builder builderFor(Table table, int partitionId, long taskId) {
- return new Builder(table, partitionId, taskId);
+ return new Builder(
+ table.locationProvider(),
+ table.encryption(),
+ table::io,
+ table.spec(),
+ FileFormat.fromString(
+ table.properties().getOrDefault(DEFAULT_FILE_FORMAT,
DEFAULT_FILE_FORMAT_DEFAULT)),
+ partitionId,
+ taskId);
+ }
+
+ public static Builder builderFor(
Review Comment:
We don't need any of these changes actually now that we pass in the output
file supplier to the DVFileWriter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
