stevenzwu commented on code in PR #15426:
URL: https://github.com/apache/iceberg/pull/15426#discussion_r2849605821
##########
core/src/main/java/org/apache/iceberg/FindFiles.java:
##########
@@ -208,18 +208,18 @@ public CloseableIterable<DataFile> collect() {
}
// when snapshot is not null
- CloseableIterable<ManifestEntry<DataFile>> entries =
- new ManifestGroup(ops.io(), snapshot.dataManifests(ops.io()))
- .specsById(ops.current().specsById())
- .filterData(rowFilter)
- .filterFiles(fileFilter)
- .filterPartitions(partitionFilter)
- .ignoreDeleted()
- .caseSensitive(caseSensitive)
- .planWith(executorService)
- .entries();
-
- return CloseableIterable.transform(entries, entry ->
entry.file().copy(includeColumnStats));
+ return new ManifestGroup(ops.io(), snapshot.dataManifests(ops.io()))
Review Comment:
I assume this change is required after we fixed the thread pool usage. the
transform need to be happened inside the `entries` execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
