blackmwk commented on code in PR #2175:
URL: https://github.com/apache/iceberg-rust/pull/2175#discussion_r2850332950
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -212,13 +212,20 @@ impl ArrowReader {
let delete_filter_rx =
delete_file_loader.load_deletes(&task.deletes,
Arc::clone(&task.schema));
+ let file_size = if task.file_size_in_bytes > 0 {
Review Comment:
In what case the `file_size_in_bytes` is not larger than 0?
##########
crates/iceberg/src/arrow/delete_filter.rs:
##########
@@ -399,6 +399,7 @@ pub(crate) mod tests {
let file_scan_tasks = vec![
FileScanTask {
+ file_size_in_bytes: 0,
Review Comment:
It's odd to see 0 size file.
##########
crates/iceberg/src/arrow/delete_file_loader.rs:
##########
@@ -64,6 +64,7 @@ impl BasicDeleteFileLoader {
self.file_io.clone(),
false,
None,
+ None,
Review Comment:
I think we should still fetch file size here.
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -2097,6 +2110,7 @@ message schema {
) -> Vec<Option<String>> {
let tasks = Box::pin(futures::stream::iter(
vec![Ok(FileScanTask {
+ file_size_in_bytes: 0,
Review Comment:
Though they are tests, I still think it's better to have a positive number .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
