nastra commented on code in PR #15368:
URL: https://github.com/apache/iceberg/pull/15368#discussion_r2851793147
##########
core/src/main/java/org/apache/iceberg/BaseScan.java:
##########
@@ -102,7 +102,8 @@ public Table table() {
return table;
}
- protected FileIO io() {
+ @Override
+ public FileIO io() {
return table.io();
}
Review Comment:
actually that's a good point. I don't think we're closing the FileIO
instance that we're creating inside `RESTTableScan`. I'll open a separate PR to
address that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
