RussellSpitzer commented on code in PR #15239:
URL: https://github.com/apache/iceberg/pull/15239#discussion_r2854699612
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##########
@@ -247,52 +267,147 @@ public void prepareForTriggerAvailableNow() {
}
}
- private static class InitialOffsetStore {
+ private abstract static class BaseOffsetStore {
+ private static final Joiner SLASH = Joiner.on("/");
+
private final Table table;
- private final FileIO io;
private final String initialOffsetLocation;
private final Long fromTimestamp;
- InitialOffsetStore(Table table, String checkpointLocation, Long
fromTimestamp) {
+ BaseOffsetStore(Table table, String checkpointLocation, Long
fromTimestamp) {
Review Comment:
Could be "long fromTimestamp"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
