ebyhr commented on code in PR #15490:
URL: https://github.com/apache/iceberg/pull/15490#discussion_r2870095552
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCatalog.java:
##########
@@ -261,6 +261,38 @@ public void testViewWithHiveParameters() throws
TException, IOException {
assertThat(hiveTable.getViewExpandedText()).isEqualTo(tableQuery);
}
+ @Test
+ public void testReplaceViewUpdatesHiveViewText() throws TException,
IOException {
Review Comment:
`IOException` is redundant.
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveViewCatalog.java:
##########
@@ -261,6 +261,38 @@ public void testViewWithHiveParameters() throws
TException, IOException {
assertThat(hiveTable.getViewExpandedText()).isEqualTo(tableQuery);
}
+ @Test
Review Comment:
This test passes even without `HiveViewOperations` change.
We fixed the similar issue in #14831. What is the difference from the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
