WZhuo commented on code in PR #559:
URL: https://github.com/apache/iceberg-cpp/pull/559#discussion_r2870434710
##########
src/iceberg/table_scan.h:
##########
@@ -293,10 +257,6 @@ class ICEBERG_EXPORT TableScan {
/// \brief Returns whether this scan is case-sensitive.
bool is_case_sensitive() const;
- /// \brief Plans the scan tasks by resolving manifests and data files.
- /// \return A Result containing scan tasks or an error.
- virtual Result<std::vector<std::shared_ptr<FileScanTask>>> PlanFiles() const
= 0;
Review Comment:
Can't override virtual method with different return type and `TableScan`
class with not be used directly. If we want to reserve it really, I can do it
later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
