nastra commented on code in PR #15175:
URL: https://github.com/apache/iceberg/pull/15175#discussion_r2870790916
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java:
##########
@@ -377,4 +378,11 @@ private String jobDesc(
table.name());
}
}
+
+ private String getPartitionDescription(StructLike partition) {
+ Preconditions.checkArgument(
+ partition instanceof StructProjection,
+ "Partition must be a StructProjection to retrieve description");
Review Comment:
I'm not sure we should be failing here. why not fallback and return an empty
string instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
