pvary commented on code in PR #15471:
URL: https://github.com/apache/iceberg/pull/15471#discussion_r2871718615
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicTableRecordGenerator.java:
##########
@@ -28,12 +33,44 @@
public abstract class DynamicTableRecordGenerator implements
DynamicRecordGenerator<RowData> {
private final RowType rowType;
+ private final Map<String, String> writeProps;
- public DynamicTableRecordGenerator(RowType rowType) {
+ public DynamicTableRecordGenerator(RowType rowType, Map<String, String>
writeProps) {
this.rowType = rowType;
+ this.writeProps = writeProps;
}
- protected RowType rowType() {
+ public RowType rowType() {
return rowType;
}
+
+ public Map<String, String> writeProps() {
+ return writeProps;
+ }
+
+ protected Map<String, Integer> getFieldPositionIndex() {
Review Comment:
no `get` in the method naming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
