Guosmilesmile commented on PR #15489: URL: https://github.com/apache/iceberg/pull/15489#issuecomment-3983736972
@pvary Thank you very much for your response. > Is dropping other dialects is intentional, or it is a bug? From the current code, it looks intentional. There is already the `replace.drop-dialect.allowed` configuration: during `REPLACE`, if this config is not enabled, the operation will fail when the number of dialects differs before and after the replace. > Given these 2 use-cases, it might be better of not adding the new config, and forcing the engines to consciously decide one or the other. Enable replace.drop-dialect.allowed, and we'll directly drop other dialects; if not set, we'll keep the case that preserves other dialects. Do you think this is feasible? The points above are my still-immature thoughts, and I’d appreciate hearing more perspectives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
