steveloughran commented on code in PR #15439:
URL: https://github.com/apache/iceberg/pull/15439#discussion_r2874270269
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -58,6 +61,17 @@ class RESTTableScan extends DataTableScan {
private static final long MAX_WAIT_TIME_MS = 5 * 60 * 1000; // Total maximum
duration (5 minutes)
private static final double SCALE_FACTOR = 2.0; // Exponential scale factor
private static final String DEFAULT_FILE_IO_IMPL =
"org.apache.iceberg.io.ResolvingFileIO";
+ private static final Cache<RESTTableScan, FileIO> TRACKER =
+ Caffeine.newBuilder()
+ .weakKeys()
+ .removalListener(
+ (RemovalListener<RESTTableScan, FileIO>)
+ (scan, io, cause) -> {
+ if (null != io) {
+ io.close();
Review Comment:
maybe log at debug in case anyone ever wants to debug this, especially in
something triggered by GC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
