talatuyarer commented on code in PR #15475:
URL: https://github.com/apache/iceberg/pull/15475#discussion_r2876800603
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/data/TestRowDataProjection.java:
##########
@@ -271,18 +271,19 @@ public void testMapOfPrimitivesProjection() {
GenericRowData.of(
StringData.fromString("row_id_value"),
new GenericMapData(
- ImmutableMap.of(StringData.fromString("foo"), 1,
StringData.fromString("bar"), 2)));
+ ImmutableMap.of(StringData.fromString("foo"), 1,
StringData.fromString("bar"), 2)),
+ null);
Review Comment:
Because I updated the `DataGenerators.MapOfPrimitives` generator to include
a third field, `map_of_ts_ns`, to test nanosecond timestamp support within map
structures.
Since `GenericRowData.of(...)` creates a fixed-size row, it must provide a
value for every field defined in the schema. Because the updated schema now has
three fields
https://github.com/apache/iceberg/pull/15475/changes#diff-e53cf1fffc0c4bd38af65ac9748b5eaf94520dc3a49526abecbd4a06d4374858R901
, the manual construction of otherRowData in the test had to be updated to
include a third argument (in this case, null).
I updated MAP and Array types and make sure convertor also support nested
nanoseconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
