steveloughran commented on PR #15171: URL: https://github.com/apache/iceberg/pull/15171#issuecomment-3992175091
If you have a request with signed headers stored somewhere and a full request needing signing, the comparison of "will this work" is a matter of comparing only the signed headers. But like you note: any hashmap lookup needs a key which is derivable from the full request, else it's some scan through many/all cached entries. So while I've been implementing the code to get the list of signed headers from the signature, it's not going to work, is it? I acknowledge problem #1. Having the client filter out all "known never signed" keys from the cache key & lookup would ensure that you'd get a match, but we would need to know every key which would _ever_ be unsigned, or at least update that list as requests come in. I'll grab some logs of s3 requests through the AWS SDK, put them up on #15428 to build that list of headers to skip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
