huaxingao commented on code in PR #15501:
URL: https://github.com/apache/iceberg/pull/15501#discussion_r2897523611
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -202,6 +203,18 @@ private static void deleteFiles(FileIO io,
Set<ManifestFile> allManifests) {
});
}
+ /**
+ * Helper to delete files. Bulk deletion is used if possible, otherwise
deletions are done
+ * concurrently for non-bulk FileIO.
+ *
+ * @param io FileIO for deletes
+ * @param files files to delete
+ * @param type type of files being deleted
+ */
+ public static void deleteFiles(FileIO io, Iterable<String> files, String
type) {
Review Comment:
nit: It looks like the 4-arg `deleteFiles(io, files, type, concurrent)` is
still public in this PR: was making it private intentionally left out, or just
missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
