zheliu2 commented on PR #15571: URL: https://github.com/apache/iceberg/pull/15571#issuecomment-4025319154
Good question — looking at the original issue more closely, the reporter was mixing `overwriteMode=true` with equality fields, which you already identified in the issue comments. So the primary scenario is indeed a user misconfiguration. That said, I'm wondering if it might still be worth handling this gracefully rather than throwing `IllegalStateException`: - The `IcebergSink` builder validates that upsert and overwrite aren't combined, but `IcebergFilesCommitter` / `IcebergCommitter` operate on `WriteResult` objects without visibility into the sink config. Could there be cases where `WriteResult` is constructed outside the standard sink path (e.g., custom operators)? - A warning + drop might be more defensive than a hard crash, since the delete files are semantically meaningless in a full partition replacement anyway. Happy to close this if you think the hard check is the right signal to the user — let me know what you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
