pvary commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2911043649
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -59,7 +59,7 @@
public class BaseTransaction implements Transaction {
private static final Logger LOG =
LoggerFactory.getLogger(BaseTransaction.class);
- enum TransactionType {
+ protected enum TransactionType {
Review Comment:
Here is my suggestion:
- Don't change any previous decisions for now
- Keep the constructors package private
- Rename cleanUpOnCommitFailure to cleanUp and make it protected - to show
that it is used elsewhere
Merge this and change the BaseTransaction visibility later if we decide so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
