rdblue commented on code in PR #15561: URL: https://github.com/apache/iceberg/pull/15561#discussion_r2913352888
########## core/src/main/java/org/apache/iceberg/SerializableFileIO.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.Map; +import org.apache.hadoop.conf.Configuration; +import org.apache.iceberg.hadoop.HadoopConfigurable; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.util.SerializableSupplier; + +public class SerializableFileIO { + private SerializableFileIO() {} + + public static FileIO copyOf(FileIO fileIO) { + if (fileIO instanceof HadoopConfigurable) { + ((HadoopConfigurable) fileIO).serializeConfWith(SerializableConfSupplier::new); + } + + return fileIO; + } + + // captures the current state of a Hadoop configuration in a serializable manner + private static class SerializableConfSupplier implements SerializableSupplier<Configuration> { Review Comment: This is the main thing that needs to be used. Why not just always use this as part of `HadoopFileIO`? Then we don't need a util class or checking to wrap the `Configuration`. We would also not have unnecessary references to `Configuration` in classes that don't require it (meaning `SerializableTable`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
