stevenzwu commented on code in PR #15575:
URL: https://github.com/apache/iceberg/pull/15575#discussion_r2913497268
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -126,6 +130,10 @@ protected ManifestReader(
if (specsById != null) {
this.spec = specsById.get(specId);
} else {
+ LOG.warn(
+ "Reading partition spec from manifest file metadata is deprecated
and will be "
+ + "removed in a future release. Pass specsById to avoid reading
from file metadata: {}",
Review Comment:
nit: `future release` --> `1.12.0 release`.
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -97,14 +97,30 @@ public static CacheMetricsReport contentCacheStats(FileIO
io) {
*
* @param manifest a ManifestFile
* @param io a FileIO
+ * @param specsById a Map from spec ID to partition spec
* @return a manifest reader
*/
- public static CloseableIterable<String> readPaths(ManifestFile manifest,
FileIO io) {
+ public static CloseableIterable<String> readPaths(
+ ManifestFile manifest, FileIO io, Map<Integer, PartitionSpec> specsById)
{
return CloseableIterable.transform(
- read(manifest, io,
null).select(ImmutableList.of("file_path")).liveEntries(),
+ read(manifest, io,
specsById).select(ImmutableList.of("file_path")).liveEntries(),
entry -> entry.file().location());
}
+ /**
+ * Returns a {@link CloseableIterable} of file paths in the {@link
ManifestFile}.
+ *
+ * @param manifest a ManifestFile
+ * @param io a FileIO
+ * @return a manifest reader
+ * @deprecated since 1.10.0, will be removed in 1.12.0; use {@link
#readPaths(ManifestFile,
Review Comment:
next release in 1.11.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
