Fokko commented on code in PR #2993:
URL: https://github.com/apache/iceberg-python/pull/2993#discussion_r2923381687
##########
tests/benchmark/test_memory_benchmark.py:
##########
@@ -95,7 +96,8 @@ def test_manifest_cache_memory_growth(memory_catalog:
InMemoryCatalog) -> None:
# Sample memory at intervals
if (i + 1) % 10 == 0:
current, _ = tracemalloc.get_traced_memory()
- cache_size = len(_manifest_cache)
+ cache = manifest_module._manifest_cache
+ cache_size = len(cache) if cache is not None else 0
Review Comment:
Do we need this check, I don't see how the cache can be `None`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
