bryanck commented on code in PR #13979:
URL: https://github.com/apache/iceberg/pull/13979#discussion_r2927245397
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -850,6 +904,24 @@ private Table load(Identifier ident, TimeTravel
timeTravel) throws NoSuchTableEx
}
}
+ private org.apache.iceberg.Table loadIcebergTable(
+ TableIdentifier ident, Map<String, Object> context) {
+ if (!context.isEmpty()
+ && icebergCatalog instanceof
org.apache.iceberg.catalog.ContextAwareCatalog) {
Review Comment:
`icebergCatalog` here could be `CachingCatalog` if caching is enabled (it is
by default), so this will only work if caching is disabled. I feel we should
store another variable, e.g. `asContextAwareCatalog`, similar to
`asViewCatalog`, that is initialized based off of the unwrapped Iceberg catalog
instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
