adp2201 commented on PR #14435: URL: https://github.com/apache/iceberg/pull/14435#issuecomment-4049956787
Thanks for pushing this forward — the performance gains are compelling. One thing I’d like to see clearly enforced is the safe-to-merge contract as hard preconditions (not just docs/fallback), especially around: 1. V3 row-lineage correctness (row-id/first-row-id semantics), 2. Presence of delete files / DVs, 3. Sort-order constraints, 4. Schema/metadata compatibility checks required for appendFile-based merge. Would it make sense to have one centralized eligibility check that returns a structured reason (or metric) for why ParquetFileMerger is skipped, plus tests that validate fallback behavior for each blocked condition? That would make this much easier to operate/debug in production while preserving correctness guarantees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
