RussellSpitzer commented on code in PR #15180:
URL: https://github.com/apache/iceberg/pull/15180#discussion_r2927400434


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4147,6 +4255,223 @@ components:
           items:
             $ref: '#/components/schemas/Namespace'
 
+    LoadFunctionResult:
+      description: |
+        Result returned when a function is loaded from the catalog.
+
+
+        The function metadata JSON is returned in the `metadata` field. The 
location of the metadata
+        file is returned in the `metadata-location` field.
+
+
+        The `config` map returns function-specific configuration for accessing 
the function's resources,
+        including any required credentials or client configuration overrides.
+      type: object
+      required:
+        - metadata-location
+        - metadata
+      properties:
+        metadata-location:
+          type: string
+        metadata:
+          $ref: '#/components/schemas/UdfMetadata'
+        config:
+          type: object
+          additionalProperties:
+            type: string
+
+    UdfMetadata:
+      description: |
+        Portable UDF metadata format.
+
+
+        Each function is represented by a self-contained metadata file. The 
`format-version` field
+        identifies the UDF metadata format.
+      type: object
+      required:
+        - function-uuid
+        - format-version
+        - definitions
+        - definition-log
+      properties:
+        function-uuid:
+          type: string
+          description: A UUID that identifies this UDF, generated once at 
creation.

Review Comment:
   Nit: should include `format: uuid` for schema validation, consistent with 
how other UUID fields are defined in the spec (e.g. `snapshot-id`, 
`table-uuid`).
   
   ```suggestion
           function-uuid:
             type: string
             format: uuid
             description: A UUID that identifies this UDF, generated once at 
creation.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to