kuldeep27396 commented on PR #15623:
URL: https://github.com/apache/iceberg/pull/15623#issuecomment-4056954833
Excellent work addressing issue #15556! 🎉
**What I love about this PR:**
1. **Fixed markdown rendering issues** - Proper capitalization of 'GitHub
Actions' and 'GitHub-hosted runners' instead of inconsistent abbreviations
2. **Consistent style throughout** - All benchmarks now follow a uniform
template with clear sections for each module type (Core, Data, Spark, Flink)
3. **Comprehensive documentation** - Added documentation for ALL benchmark
groups including:
- Core benchmarks (9 benchmarks)
- Data benchmarks (3 benchmarks)
- Spark action benchmarks (2 benchmarks)
- Spark Parquet reader/writer benchmarks (4 benchmarks)
- Spark source benchmarks (21 benchmarks!)
- Spark extensions benchmarks (5 benchmarks)
- Flink benchmarks (4 benchmarks)
4. **Better organization** - Clear command templates, version information,
and logical grouping make it much easier for developers to find and run
benchmarks
5. **Added missing context** - Information about JMH output paths, default
versions, and how to use different Spark/Flink versions
The documentation is now production-ready and will significantly help
developers understand and use the benchmarking infrastructure. This is exactly
what was requested in the issue and more!
**LGTM!** 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
