rdblue commented on code in PR #15613:
URL: https://github.com/apache/iceberg/pull/15613#discussion_r2933048361
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -228,71 +226,45 @@ private FileIO scanFileIO(List<Credential>
storageCredentials) {
}
private CloseableIterable<FileScanTask> fetchPlanningResult() {
- RetryPolicy<FetchPlanningResultResponse> retryPolicy =
- RetryPolicy.<FetchPlanningResultResponse>builder()
- .handleResultIf(response -> response.planStatus() ==
PlanStatus.SUBMITTED)
- .withBackoff(
- Duration.ofMillis(MIN_SLEEP_MS),
Duration.ofMillis(MAX_SLEEP_MS), SCALE_FACTOR)
- .withJitter(0.1) // Add jitter up to 10% of the calculated delay
- .withMaxAttempts(MAX_ATTEMPTS)
- .withMaxDuration(Duration.ofMillis(MAX_WAIT_TIME_MS))
- .onFailedAttempt(
- e -> {
- // Log when a retry occurs
- LOG.debug(
- "Plan {} still SUBMITTED (Attempt {}/{}). Previous
attempt took {} ms.",
- planId,
- e.getAttemptCount(),
- MAX_ATTEMPTS,
- e.getElapsedAttemptTime().toMillis());
- })
- .onFailure(
- e -> {
- LOG.warn(
- "Polling for plan {} failed due to: {}",
- planId,
- e.getException().getMessage());
- cleanupPlanResources();
- })
- .build();
+ AtomicReference<FetchPlanningResultResponse> result = new
AtomicReference<>();
+ Tasks.foreach(planId)
+ .exponentialBackoff(MIN_SLEEP_MS, MAX_SLEEP_MS, MAX_WAIT_TIME_MS,
SCALE_FACTOR)
+ .retry(MAX_ATTEMPTS)
Review Comment:
Minor: We might want to rename MAX_ATTEMPTS to MAX_RETRIES. I think that the
number of attempts is retries + 1 (the initial attempt). Not a big deal, but
probably more clear in the long run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
