anuragmantri commented on code in PR #15470:
URL: https://github.com/apache/iceberg/pull/15470#discussion_r2934166130
##########
.palantir/revapi.yml:
##########
@@ -1408,12 +1408,41 @@ acceptedBreaks:
\ java.io.IOException"
justification: "Removing deprecated code for 1.11.0"
- code: "java.method.removed"
+ old: "method
org.apache.iceberg.RewriteTablePathUtil.RewriteResult<org.apache.iceberg.DeleteFile>\
+ \
org.apache.iceberg.RewriteTablePathUtil::rewriteDeleteManifest(org.apache.iceberg.ManifestFile,\
+ \ java.util.Set<java.lang.Long>, org.apache.iceberg.io.OutputFile,
org.apache.iceberg.io.FileIO,\
+ \ int, java.util.Map<java.lang.Integer,
org.apache.iceberg.PartitionSpec>,\
+ \ java.lang.String, java.lang.String, java.lang.String) throws
java.io.IOException"
+ justification: "Position delete files are now rewritten inline during
manifest\
+ \ writing to fix file_size_in_bytes"
+ - code: "java.method.numberOfParametersChanged"
old: "method
org.apache.iceberg.RewriteTablePathUtil.RewriteResult<org.apache.iceberg.DeleteFile>\
\
org.apache.iceberg.RewriteTablePathUtil::rewriteDeleteManifest(org.apache.iceberg.ManifestFile,\
\ org.apache.iceberg.io.OutputFile, org.apache.iceberg.io.FileIO, int,
java.util.Map<java.lang.Integer,\
\ org.apache.iceberg.PartitionSpec>, java.lang.String,
java.lang.String, java.lang.String)\
\ throws java.io.IOException"
- justification: "Removing deprecated code for 1.11.0"
+ new: "method
org.apache.iceberg.RewriteTablePathUtil.RewriteResult<org.apache.iceberg.DeleteFile>\
+ \
org.apache.iceberg.RewriteTablePathUtil::rewriteDeleteManifest(org.apache.iceberg.ManifestFile,\
+ \ java.util.Set<java.lang.Long>, org.apache.iceberg.io.OutputFile,
org.apache.iceberg.io.FileIO,\
+ \ int, java.util.Map<java.lang.Integer,
org.apache.iceberg.PartitionSpec>,\
+ \ java.lang.String, java.lang.String, java.lang.String,
org.apache.iceberg.RewriteTablePathUtil.PositionDeleteReaderWriter)\
+ \ throws java.io.IOException"
+ justification: "Position delete files are now rewritten inline during
manifest\
+ \ writing to fix file_size_in_bytes"
+ - code: "java.element.noLongerDeprecated"
Review Comment:
Sorry I'm a bit confused because I don't understand the revapi tool. Why
does this say un-deprecating the old 8 param version?
Old (deprecated) - 8 params
Current (main) - 9 params
New (this PR) - 10 params
Shouldn't we still deprecate the old 8 param version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
