pvary commented on code in PR #15633:
URL: https://github.com/apache/iceberg/pull/15633#discussion_r2954326584
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -66,6 +76,11 @@ public abstract class BaseFormatModelTests<T> {
private static final FileFormat[] FILE_FORMATS =
new FileFormat[] {FileFormat.AVRO, FileFormat.PARQUET, FileFormat.ORC};
+ private static final List<Arguments> FORMAT_AND_DEFAULT_GENERATOR =
+ Arrays.stream(FILE_FORMATS)
+ .map(format -> Arguments.of(format, new
DataGenerators.DefaultSchema()))
+ .toList();
Review Comment:
Do we need this, or `FILE_FORMATS` is enough and we just use `new
DataGenerators.DefaultSchema()` in the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
