CTTY commented on code in PR #2246:
URL: https://github.com/apache/iceberg-rust/pull/2246#discussion_r2954739975
##########
bindings/python/src/datafusion_table_provider.rs:
##########
@@ -110,7 +86,7 @@ impl PyIcebergDataFusionTable {
let table_ident = TableIdent::from_strs(identifier)
.map_err(|e| PyRuntimeError::new_err(format!("Invalid table
identifier: {e}")))?;
- let factory = storage_factory_from_path(&metadata_location)?;
+ let factory = Arc::new(OpenDalResolvingStorageFactory::new());
Review Comment:
totally agree that we should expose something like this to Pyiceberg
There is a tracking issue to expose storage factory as a configurable item
to Pyiceberg: https://github.com/apache/iceberg-rust/issues/2200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
