CTTY commented on code in PR #2232:
URL: https://github.com/apache/iceberg-rust/pull/2232#discussion_r2956348461
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -95,8 +96,17 @@ pub trait Catalog: Debug + Sync + Send {
/// Load table from the catalog.
async fn load_table(&self, table: &TableIdent) -> Result<Table>;
+ /// Drop a table from the catalog and purge its data, or returns error if
it doesn't exist.
+ ///
+ /// This is equivalent to calling `drop_table_with_purge(table, true)`.
+ async fn drop_table(&self, table: &TableIdent) -> Result<()> {
+ self.drop_table_with_purge(table, true).await
Review Comment:
I think a new API purge_table may make more sense. Then it's up to the
engine/catalog to decide when to call which
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
