RussellSpitzer commented on code in PR #15614:
URL: https://github.com/apache/iceberg/pull/15614#discussion_r2957081423
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -375,6 +383,26 @@ public boolean purgeTable(Identifier ident) {
String metadataFileLocation =
((HasTableOperations)
table).operations().current().metadataFileLocation();
+ boolean isRestCatalog =
+ this.icebergCatalog instanceof RESTCatalog
+ || this.icebergCatalog instanceof RESTSessionCatalog
+ || (this.icebergCatalog instanceof CachingCatalog
+ && ((CachingCatalog)
this.icebergCatalog).wrapped_is_instance(RESTCatalog.class));
+
+ if (isRestCatalog && this.restCatalogPurge) {
+ // Delegate purge to REST catalog - allows server-side features like
UNDROP
+ return dropTableWithPurging(ident);
+ }
Review Comment:
Could just chain this with the next branch or combine
```java
if (rest + purge) {
...
} else if (rest) {
...
}
```
or
```java
if (rest) {
if (purge) {
...
} else {
...
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
