wgtmac commented on code in PR #590:
URL: https://github.com/apache/iceberg-cpp/pull/590#discussion_r2964139049
##########
src/iceberg/table_scan.h:
##########
@@ -132,6 +133,17 @@ struct TableScanContext {
// Validate the context parameters to see if they have conflicts.
[[nodiscard]] Status Validate() const;
+
+ /// \brief Returns true if this scan is a current lineage scan, which means
it does not
+ /// specify from/to snapshot IDs.
+ bool IsScanCurrentLineage() const;
Review Comment:
Can we just move these three new functions to the anonymous namespace in the
table_scan.cc?
##########
src/iceberg/table_scan.h:
##########
@@ -373,6 +383,26 @@ class ICEBERG_EXPORT IncrementalScan : public TableScan {
using TableScan::TableScan;
};
+// Template method implementation (must be in header for MSVC)
+template <typename ScanTaskType>
+Result<std::vector<std::shared_ptr<ScanTaskType>>>
+IncrementalScan<ScanTaskType>::PlanFiles() const {
+ if (context_.IsScanCurrentLineage()) {
+ ICEBERG_ASSIGN_OR_RAISE(auto current_snapshot, metadata_->Snapshot());
Review Comment:
Do we need to consider if branch has been specified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
