varun-lakhyani commented on code in PR #15341:
URL: https://github.com/apache/iceberg/pull/15341#discussion_r2967471247
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/BaseReader.java:
##########
@@ -134,6 +156,14 @@ public boolean next() throws IOException {
if (currentIterator.hasNext()) {
this.current = currentIterator.next();
return true;
+ } else if (isAsyncEnabled) {
+ this.currentIterator.close();
Review Comment:
Updated in latest commit.
For renaming currentIterator to sequentialIterator, I am not sure renaming
is good idea as of now for POC and benchmarking purpose as its been named this
for a while, Can think of it afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
