RSP22 commented on PR #806:
URL: https://github.com/apache/iceberg-go/pull/806#issuecomment-4105449954
Added `table/addfiles_merge_regression_test.go` as a standalone file rather
than
adding to `transaction_test.go` for the following reasons:
1. **Three existing tests already set `commit.manifest-merge.enabled=true`
but none
call `AddFiles()`** — the gap is specific to `AddFiles()` and a separate
file makes
that immediately visible to anyone searching for test coverage.
2. **Regression tests are easier to find when named after the bug** —
`addfiles_merge_regression_test.go` signals its purpose: prevent this
specific
regression from recurring. Contributors can locate it without reading
`transaction_test.go` in full.
Happy to move it into `transaction_test.go` if preferred — the test itself
is unchanged either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
